Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix - GPlay Variant E2E Dialog #14348

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Jan 8, 2025

  • Tests written, or not not needed

How to reproduce?

  1. Run the app in the Google Play variant.
  2. Attempt to create an encrypted folder.

How to Test?

  • Attempt to create or open an encrypted folder with all available variants

After:

aa.mp4

Before:

b.mp4

@alperozturk96 alperozturk96 requested a review from ZetaTom January 8, 2025 13:05
@alperozturk96 alperozturk96 force-pushed the bugfix/g-play-setup-e2e branch 3 times, most recently from 479fd87 to 8fecc7d Compare January 9, 2025 15:49
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 alperozturk96 force-pushed the bugfix/g-play-setup-e2e branch from 8fecc7d to 9670a9a Compare January 13, 2025 09:12
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14348.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Copy link

Codacy

Lint

TypemasterPR
Warnings5656
Errors33

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness5858
Dodgy code296296
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness77
Performance5353
Security1818
Total506506

@tobiasKaminsky tobiasKaminsky merged commit ee28629 into master Jan 13, 2025
20 of 22 checks passed
@tobiasKaminsky tobiasKaminsky deleted the bugfix/g-play-setup-e2e branch January 13, 2025 12:44
@alperozturk96
Copy link
Collaborator Author

/backport to stable-3.30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants